Add anchors to policy sub-sections #2049
Open
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebloor
reviewed
Apr 12, 2025
| @@ -45,7 +46,7 @@ When an add-on is given human review or otherwise assessed by Mozilla, these pol | |||
|
|
|||
| Users should be able to easily discern the functionality of your add-on based on the listing, and should not be presented with unexpected user experiences after installing it. The listing should include an easy-to-read description of what the add-on does, and what information it collects. Please consult our best practices guide for [creating an appealing listing](/documentation/develop/create-an-appealing-listing/). | |||
|
|
|||
| ### Unexpected features | |||
| ### <span id="unexpected-features"></span>Unexpected features | |||
There was a problem hiding this comment.
@dotproto I assume you've tested and these work as expected? I ask, as it appears that the "correct" way of doing this would be like this, as per develop.md:
<section id="user-experience" class="page-section-container">
<!-- Single Column Body Module -->
{% capture content %}
## User Experience
{% endcapture %}
{% include modules/one-column.liquid,
content: content
%}
<!-- END: Single Column Body Module -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a long standing frustration of mine: it's not possible to link developers directly to a sub-section of the add-ons policies. To address this, I've manually hacked in
<span>tags with ID attributes to the H3 and H4 elements on the policies page.Ideally we would have a more robust way of generating header anchors but for now this is better than nothing.